[Differential] [Request, 177 lines] D722: Get rid off TestProjectController

[kfunk (Kevin Funk)]

kfunk created this revision.
Herald added a subscriber: kdevelop-devel.

REVISION SUMMARY
  A test in kdev-ruby fails, and the root problem is that
  TestProjectController destroys some of the semantics of its
  ProjectController base. ProjectController isn't able to delete projects
  in such cases => leads to strange issues in the end.
  
  Fix for good: Remove TestProjectController, and add a little more API to
  IProject & IProjectController which we can access from unit tests.
  
  Also leads to a cleaner implementation of
  ProjectController::closeProject (no cast to Project* needed anymore).

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D722

AFFECTED FILES
  interfaces/iproject.h
  interfaces/iprojectcontroller.h
  plugins/quickopen/tests/bench_quickopen.cpp
  plugins/quickopen/tests/quickopentestbase.cpp
  plugins/quickopen/tests/quickopentestbase.h
  plugins/quickopen/tests/test_quickopen.cpp
  project/tests/test_projectmodel.cpp
  shell/project.h
  shell/projectcontroller.cpp
  shell/projectcontroller.h
  tests/testproject.cpp
  tests/testproject.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk
Cc: kdevelop-devel