[Differential] [Commented On] D669: Fix default CMake generator setting.

[kfunk (Kevin Funk)]

kfunk added a subscriber: kfunk.
kfunk added a comment.

Looks good to me in general.

Please add `BUG: 356875` to commit message.


INLINE COMMENTS
  projectbuilders/cmakebuilder/cmakebuilderpreferences.cpp:46 Prefer `foreach` on Qt containers.
  
  (Details: http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/)
  projectbuilders/cmakebuilder/cmakebuilderpreferences.cpp:46 Style: `const QString&`, same in other locations
  projectbuilders/cmakebuilder/cmakebuilderpreferences.cpp:63 I think you can remove the `default`, `apply`, `reset` overrides here now completely(?)

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D669

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arrowdodger, KDevelop
Cc: kfunk, kdevelop-devel, arrowdodger