[Differential] [Commented On] D667: Don't append -k and -j flags to command line when we are using nmake.

[kfunk (Kevin Funk)]

kfunk added a subscriber: kfunk.
kfunk added a comment.

Looks good to me in general. +1.


INLINE COMMENTS
  projectbuilders/makebuilder/makebuilderpreferences.cpp:81 Nitpick: `if ( foo )` -> `if (foo)`
  projectbuilders/makebuilder/makejob.cpp:185 Let's factor the `makeBin != ...` out in some free `bool isUnixMake(const QString& makeBin)` function.
  
  Also: `makeBin` could be a fully-qualified path, protect against this.

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D667

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arrowdodger, KDevelop
Cc: kfunk, kdevelop-devel, arrowdodger