[Differential] [Changed Subscribers] D660: OutputView: Filter ANSI sequences
mwolff (Milian Wolff)
noreply at phabricator.kde.org
Thu Dec 17 13:20:00 UTC 2015
mwolff added a subscriber: mwolff.
INLINE COMMENTS
outputview/outputmodel.cpp:70 isn't it a bit overkill to have a qvector if we just have one function, and that one is even known at compile time?
I'd prefer if we simplify the code and make it only as complicated as needed:
std::transform(m_cachedLines.begin(), m_cachedLines.end(), KDevelop::stripAnsiSequences);
REPOSITORY
rKDEVPLATFORM KDevPlatform
REVISION DETAIL
https://phabricator.kde.org/D660
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk
Cc: mwolff, apol, kdevelop-devel, arrowdodger
More information about the KDevelop-devel
mailing list