[Differential] [Accepted] D622: Open File: Use KEncodingFileDialog only under KDE

[amccann (Andrew McCann)]

amccann added a subscriber: amccann.
amccann accepted this revision.
amccann added a reviewer: amccann.
amccann added a comment.
This revision is now accepted and ready to land.

Tested on OSX, commented on a minor issue inline.


INLINE COMMENTS
  shell/documentcontroller.cpp:147 On OSX, having tried this patch, this QFileDialog::getOpenFileUrls() does succeed in presenting a native 'open file' dialog.
  
  However, the 'filter' argument doesn't work as desired. It just displays the raw "*|Text File" string, which looks out of place, and doesn't cause any filtering.
  
  http://doc.qt.io/qt-5/qfiledialog.html#getOpenFileNames
  
  QT documentation appears to want a different syntax for filters. I tried the following just to verify understanding:
  ```
  "Text Files (*);;C Files(*.c)"
  ```
  It worked.
  
  However, when it is reduced to:
  ```
  "Text Files (*)"
  ```
  Something it optimizing away the filter altogether, resulting in no filter functionality. (Which is probably fine).
  
  Given this knowledge: It may make sense to not pass any filter at all, since it isn't actually filtering anything. It appears to simply be a placeholder for the Widget that is present on KDE dialog.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D622

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, KDevelop, amccann
Cc: amccann, kdevelop-devel, arrowdodger