Review Request 124934: Fix declaration tooltip flickering

Maciej Cencora m.cencora at gmail.com
Thu Aug 27 13:08:16 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124934/
-----------------------------------------------------------

(Updated Aug. 27, 2015, 1:08 p.m.)


Review request for KDevelop.


Changes
-------

Applied review comments. Additional check for null parentContext


Repository: kdevplatform


Description
-------

Actually make use of ActiveToolTip::addExtendedRect (renamed to setHandleRect).
This functionality was lost with d77a4ecda51c324eec589167da3214d21a1eff42

Minor change was also needed in itemRangeUnderCursor:
DUContext::findContextAt for cursor at function name returns the function's context, searching for function's name inside it will fail - we need to search in parent context.


Diffs (updated)
-----

  language/duchain/duchainutils.cpp a1ff0f5 
  util/activetooltip.cpp e45116c 

Diff: https://git.reviewboard.kde.org/r/124934/diff/


Testing
-------

Manual


Thanks,

Maciej Cencora

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150827/7b0fefd8/attachment.html>


More information about the KDevelop-devel mailing list