Review Request 124934: Fix declaration tooltip flickering

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124934/#review84420
-----------------------------------------------------------



language/duchain/duchainutils.cpp (line 342)
<https://git.reviewboard.kde.org/r/124934/#comment58443>

    please add braces



language/duchain/duchainutils.cpp (line 343)
<https://git.reviewboard.kde.org/r/124934/#comment58440>

    can you give me an example code and explicit instructions to trigger this bug? recursive functions e.g. should work fine - and they do in principal just what you say: finding the function in its own context.
    
    also, this should be a separate commit. ideally, it should also be covered by a unit test in oldcpp or kdev-clang, depending on what you used for testing.



util/activetooltip.cpp (line 210)
<https://git.reviewboard.kde.org/r/124934/#comment58442>

    if `handleRect_` is invalid, will this affect the union?



util/activetooltip.cpp (line 211)
<https://git.reviewboard.kde.org/r/124934/#comment58441>

    join with next line please


- Milian Wolff


On Aug. 26, 2015, 3:01 p.m., Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124934/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 3:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Actually make use of ActiveToolTip::addExtendedRect (renamed to setHandleRect).
> This functionality was lost with d77a4ecda51c324eec589167da3214d21a1eff42
> 
> Minor change was also needed in itemRangeUnderCursor:
> DUContext::findContextAt for cursor at function name returns the function's context, searching for function's name inside it will fail - we need to search in parent context.
> 
> 
> Diffs
> -----
> 
>   language/duchain/duchainutils.cpp a1ff0f5 
>   plugins/contextbrowser/contextbrowser.cpp 268679f 
>   plugins/patchreview/patchhighlighter.cpp 48dd127 
>   shell/mainwindow_p.cpp 134d48d 
>   shell/workingsets/workingsettoolbutton.cpp 2efadb9 
>   util/activetooltip.h 35b25c0 
>   util/activetooltip.cpp e45116c 
> 
> Diff: https://git.reviewboard.kde.org/r/124934/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150826/7db7c989/attachment.html>