Review Request 124833: More fixes

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124833/#review84234
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Aug. 20, 2015, 9:24 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124833/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 9:24 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> - Introduce `UsrComparator` - I finally found something I was looking for for months: declaration name mangler used by Clang Unified Symbol Resolution. Introduced `UsrComparator` which uses `clang::index::generateUSRForDecl` to get mangled name and compares declarations by mangled name. It will improve everything and can deprecate `DeclarationSymbol`.
> - Improve type inference in Change Signature refactoring (`toString(QualType)`)
> - Fix (`Decl` pointer -> `LexicalLocation`) and improve TUDeclDispatcher (half of day spent on this: http://clang.llvm.org/doxygen/ExprCXX_8cpp_source.html#l00547)
> - improve type inference everywhere
> - clean up dependencies is CMakeLists.txt
> - ignore implicit casts in encapsulate field refactoring (like derived to base)
> - fix move function (place function definition only in record definition)
> - workaround issues in deduplication code in DocumentChangeSet
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/changesignaturerefactoring.h PRE-CREATION 
>   refactoring/changesignaturerefactoring.cpp PRE-CREATION 
>   refactoring/changesignaturerefactoringinfopack.h PRE-CREATION 
>   refactoring/changesignaturerefactoringinfopack.cpp PRE-CREATION 
>   refactoring/contextmenumutator.cpp PRE-CREATION 
>   refactoring/debug.cpp PRE-CREATION 
>   refactoring/documentcache.h PRE-CREATION 
>   refactoring/documentcache.cpp PRE-CREATION 
>   refactoring/encapsulatefieldrefactoring.h PRE-CREATION 
>   refactoring/encapsulatefieldrefactoring.cpp PRE-CREATION 
>   refactoring/encapsulatefieldrefactoring_changepack.h PRE-CREATION 
>   refactoring/encapsulatefieldrefactoring_changepack.cpp PRE-CREATION 
>   refactoring/extractfunctionrefactoring.cpp PRE-CREATION 
>   refactoring/extractvariablerefactoring.cpp PRE-CREATION 
>   refactoring/instancetostaticrefactoring.h PRE-CREATION 
>   refactoring/instancetostaticrefactoring.cpp PRE-CREATION 
>   refactoring/movefunctionrefactoring.h PRE-CREATION 
>   refactoring/movefunctionrefactoring.cpp PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
>   refactoring/tudecldispatcher.h PRE-CREATION 
>   refactoring/tudecldispatcher.cpp PRE-CREATION 
>   refactoring/usrcomparator.h PRE-CREATION 
>   refactoring/usrcomparator.cpp PRE-CREATION 
>   refactoring/utils.h PRE-CREATION 
>   refactoring/utils.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124833/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150823/797015a7/attachment.html>