Review Request 124745: Always attach AST to the active document

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124745/#review84232
-----------------------------------------------------------

Ship it!


yep that looks much better - thanks!


clangparsejob.cpp (line 240)
<https://git.reviewboard.kde.org/r/124745/#comment58327>

    couldn't you just update the highlight then and still return? it's a single function call.



clangsupport.cpp (line 392)
<https://git.reviewboard.kde.org/r/124745/#comment58328>

    make this TopDUContext::Features, otherwise you access `ctx->features()` without holding the lock - potentially bad.



clangsupport.cpp (line 395)
<https://git.reviewboard.kde.org/r/124745/#comment58329>

    please put `doc->url()` once into an `IndexedString` at the beginning of the function and then use it here and below.


- Milian Wolff


On Aug. 22, 2015, 9 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124745/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2015, 9 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This should fix the issue when we had no code completion after restoring context from disk, if the active document wasn't modified beforehand.
> 
> 
> Diffs
> -----
> 
>   clangparsejob.h ba2d5ac 
>   clangparsejob.cpp a80433e 
>   clangsupport.h a047382 
>   clangsupport.cpp 22b6c96 
>   codecompletion/model.cpp 57902d3 
>   duchain/duchainutils.h 5b1a525 
>   duchain/duchainutils.cpp 89efda7 
>   tests/test_duchain.h 694f5a2 
>   tests/test_duchain.cpp 796e3c6 
> 
> Diff: https://git.reviewboard.kde.org/r/124745/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150823/2902f483/attachment.html>