Review Request 124833: More fixes

Maciej Poleski d82ks8djf82msd83hf8sc02lqb5gh5 at gmail.com
Thu Aug 20 00:06:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124833/
-----------------------------------------------------------

Review request for KDevelop.


Repository: kdev-clang


Description
-------

- Introduce `UsrComparator` - I finally found something I was looking for for months: declaration name mangler used by Clang Unified Symbol Resolution. Introduced `UsrComparator` which uses `clang::index::generateUSRForDecl` to get mangled name and compares declarations by mangled name. It will improve everything and can deprecate `DeclarationSymbol`.
- Improve type inference in Change Signature refactoring (`toString(QualType)`)
- Fix (`Decl` pointer -> `LexicalLocation`) and improve TUDeclDispatcher (half of day spent on this: http://clang.llvm.org/doxygen/ExprCXX_8cpp_source.html#l00547)


Diffs
-----

  refactoring/CMakeLists.txt PRE-CREATION 
  refactoring/changesignaturerefactoring.h PRE-CREATION 
  refactoring/changesignaturerefactoring.cpp PRE-CREATION 
  refactoring/changesignaturerefactoringinfopack.h PRE-CREATION 
  refactoring/changesignaturerefactoringinfopack.cpp PRE-CREATION 
  refactoring/contextmenumutator.cpp PRE-CREATION 
  refactoring/debug.cpp PRE-CREATION 
  refactoring/movefunctionrefactoring.h PRE-CREATION 
  refactoring/movefunctionrefactoring.cpp PRE-CREATION 
  refactoring/refactoringmanager.cpp PRE-CREATION 
  refactoring/tudecldispatcher.h PRE-CREATION 
  refactoring/tudecldispatcher.cpp PRE-CREATION 
  refactoring/usrcomparator.h PRE-CREATION 
  refactoring/usrcomparator.cpp PRE-CREATION 
  refactoring/utils.h PRE-CREATION 
  refactoring/utils.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124833/diff/


Testing
-------


Thanks,

Maciej Poleski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150820/f96533e5/attachment.html>


More information about the KDevelop-devel mailing list