Review Request 124637: ContextMenuMutator - fix - remove (manually created) submenu when parent menu is hid

Milian Wolff mail at milianw.de
Wed Aug 19 09:12:12 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124637/#review84033
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Aug. 5, 2015, 10:37 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124637/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 10:37 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> ContextMenuMutator - remove manually created submenu when parent menu is hid
> 
> It looks like context menu is long living. But every new opening populates with (potentially) new "Refactorings" submenu.
> This fix introduces event filter watching for hide events on context menu (but only if submenu was created). hide event -> `submenu->deleteLater()`
> 
> 
> Diffs
> -----
> 
>   refactoring/contextmenumutator.h PRE-CREATION 
>   refactoring/contextmenumutator.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124637/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150819/de5959c1/attachment.html>


More information about the KDevelop-devel mailing list