Review Request 124810: Bigger or smaller fixes

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124810/#review84023
-----------------------------------------------------------

Ship it!



refactoring/movefunctionrefactoring.h (line 53)
<https://git.reviewboard.kde.org/r/124810/#comment58204>

    A (shorter) type alias for `llvm::ErrorOr<...>` would make sense IMO


- Kevin Funk


On Aug. 18, 2015, 11:48 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124810/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 11:48 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> - Verbose failure for Replacements translation
> - Improve type inference for Extract Variable refactoring
> - Protect against crash resulting from race in CompilationDatabase handling code (ComposedCompilationDatabase wip on separate branch)
> - Report error when Move refactoring is unable to locate target class
> 
> 
> Diffs
> -----
> 
>   refactoring/contextmenumutator.cpp PRE-CREATION 
>   refactoring/extractvariablerefactoring.cpp PRE-CREATION 
>   refactoring/kdevrefactorings.cpp PRE-CREATION 
>   refactoring/movefunctionrefactoring.h PRE-CREATION 
>   refactoring/movefunctionrefactoring.cpp PRE-CREATION 
>   refactoring/refactoring.h PRE-CREATION 
>   refactoring/refactoring.cpp PRE-CREATION 
>   refactoring/refactoringcontext.h PRE-CREATION 
>   refactoring/refactoringcontext.cpp PRE-CREATION 
>   tests/test_movefunction.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124810/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150819/0e05aa77/attachment.html>