Review Request 122366: Documentation View plugin history bug fixed

Kevin Funk kfunk at kde.org
Tue Aug 18 18:04:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122366/#review84007
-----------------------------------------------------------



documentation/documentationview.cpp (line 164)
<https://git.reviewboard.kde.org/r/122366/#comment58191>

    Not that easy. IDocumentation::name is not a unique key we can filter by. IDocumentation would need to be extended to provide an id or something.


- Kevin Funk


On Feb. 1, 2015, 5:22 p.m., Sebastien Speierer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122366/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2015, 5:22 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> In the Documentation View plugin, the history was keeping track of a document several times if this one was requested several times in a row. This patch fix this bug.
> 
> 
> Diffs
> -----
> 
>   documentation/documentationview.cpp fc242af 
>   kdevplatform.kdev4 d8cb86e 
> 
> Diff: https://git.reviewboard.kde.org/r/122366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastien Speierer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150818/42253ab0/attachment.html>


More information about the KDevelop-devel mailing list