Review Request 124514: Don't crash on Q_ASSERT(!jobs.contains(nullptr)) if cancelling the builder config dialog

Friedrich W. H. Kossebau kossebau at
Tue Aug 18 17:57:59 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 18, 2015, 7:57 p.m.)


This change has been discarded.

Review request for KDevelop and Aleix Pol Gonzalez.

Repository: kdevelop


Seems `IProjectBuilder::build(ProjectBaseItem *item)` does not require that a job is returned, at least `CMakeBuilder` feels free to just return `0`, e.g. if the user cancels the dialog.

Thus `CMakeManager::createImportJob(ProjectFolderItem* item)` better deals with that, and only adds the result to the call of that method to jobs if it really is a job. Not only because `Q_ASSERT(!jobs.contains(nullptr));` a few lines later will complain badly to anyone running a debug build... ;)

No idea if `KDevelop::AbstractFileManagerPlugin::createImportJob()` should get the same handling, not investigated, only ran in the issue handled here.


  projectmanagers/cmake/cmakemanager.cpp 2b18fb5 




Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list