Review Request 124802: Make assistants tests pass
Kevin Funk
kfunk at kde.org
Tue Aug 18 17:27:20 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124802/#review84000
-----------------------------------------------------------
Ship it!
Ship It!
duchain/clangducontext.cpp (line 46)
<https://git.reviewboard.kde.org/r/124802/#comment58190>
Nitpick: Space after keyword
- Kevin Funk
On Aug. 18, 2015, 10:12 a.m., Sergey Kalinichev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124802/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 10:12 a.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdev-clang
>
>
> Description
> -------
>
> This fixes two tests and expects failure of two other.
>
> One test failed because it couldn't find anonymous function parameters, and another one because of id was used when editing function definition
>
>
> Diffs
> -----
>
> codegen/adaptsignatureaction.cpp 8496004
> duchain/builder.cpp d60b66f
> duchain/clangducontext.cpp ac3dcc8
> tests/files/variables.cpp 726c5e4
> tests/test_assistants.cpp 280d7e7
>
> Diff: https://git.reviewboard.kde.org/r/124802/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Kalinichev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150818/4aa9d15a/attachment.html>
More information about the KDevelop-devel
mailing list