Review Request 123976: Fixed check for QGuiApplication during start of debug session

Kevin Funk kfunk at kde.org
Mon Aug 17 21:51:09 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123976/#review83966
-----------------------------------------------------------


Pushed, thanks for the patch!

```
commit f4acf9aeca8ce10ac9d5cc900e575ebd3af6c980
Author: Vladimir Novikov <vlrnov at gmail.com>
Date:   Mon Aug 10 10:21:12 2015 +0200

    Fixed check for QGuiApplication during start of debug session
    
    qobject_cast should return not null in case if qApp is QGuiApplication. According qFatal text it should be null to produce an error.
    
    Testing Done:
    Debugger starts in kdevelop session, not crashing with "You need a graphical application." error.
    
    REVIEW: 123967
    
    Reviewed at https://git.reviewboard.kde.org/r/123976/
```

- Kevin Funk


On June 1, 2015, 4:54 p.m., Vladimir Novikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123976/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 4:54 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> qobject_cast should return not null in case if qApp is QGuiApplication. According qFatal text it should be null to produce an error.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/debugsession.cpp fe015ae 
> 
> Diff: https://git.reviewboard.kde.org/r/123976/diff/
> 
> 
> Testing
> -------
> 
> Debugger starts in kdevelop session, not crashing with "You need a graphical application." error.
> 
> 
> Thanks,
> 
> Vladimir Novikov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150817/39332b88/attachment-0001.html>


More information about the KDevelop-devel mailing list