Review Request 124796: Add some documentation

Kevin Funk kfunk at kde.org
Mon Aug 17 21:48:07 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124796/#review83965
-----------------------------------------------------------

Ship it!



refactoring/extractvariablerefactoring.cpp (line 90)
<https://git.reviewboard.kde.org/r/124796/#comment58166>

    `/// Foo`
    
    With just two slashes it's not detected as doxygen comment



refactoring/instancetostaticrefactoring.cpp (line 84)
<https://git.reviewboard.kde.org/r/124796/#comment58167>

    `QStringLiteral`


- Kevin Funk


On Aug. 17, 2015, 8:20 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124796/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 8:20 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Add some (API) documentation
> 
> and also remove no longer necessary NoopRefactoring
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/actionwatcher.h PRE-CREATION 
>   refactoring/changesignaturedialog.h PRE-CREATION 
>   refactoring/changesignaturerefactoring.h PRE-CREATION 
>   refactoring/changesignaturerefactoringchangepack.h PRE-CREATION 
>   refactoring/changesignaturerefactoringinfopack.h PRE-CREATION 
>   refactoring/contextmenumutator.h PRE-CREATION 
>   refactoring/declarationcomparator.h PRE-CREATION 
>   refactoring/declarationsymbol.h PRE-CREATION 
>   refactoring/documentcache.h PRE-CREATION 
>   refactoring/encapsulatefielddialog.h PRE-CREATION 
>   refactoring/encapsulatefieldrefactoring.h PRE-CREATION 
>   refactoring/encapsulatefieldrefactoring_changepack.h PRE-CREATION 
>   refactoring/extractfunctionrefactoring.h PRE-CREATION 
>   refactoring/extractvariablerefactoring.h PRE-CREATION 
>   refactoring/extractvariablerefactoring.cpp PRE-CREATION 
>   refactoring/instancetostaticrefactoring.h PRE-CREATION 
>   refactoring/instancetostaticrefactoring.cpp PRE-CREATION 
>   refactoring/kdevrefactorings.h PRE-CREATION 
>   refactoring/kdevrefactorings_disabled.h PRE-CREATION 
>   refactoring/movefunctionrefactoring.h PRE-CREATION 
>   refactoring/nooprefactoring.h PRE-CREATION 
>   refactoring/nooprefactoring.cpp PRE-CREATION 
>   refactoring/redeclarationchain.h PRE-CREATION 
>   refactoring/refactoring.h PRE-CREATION 
>   refactoring/refactoring.cpp PRE-CREATION 
>   refactoring/refactoringcontext.h PRE-CREATION 
>   refactoring/refactoringcontext.cpp PRE-CREATION 
>   refactoring/refactoringcontext_worker.cpp PRE-CREATION 
>   refactoring/refactoringinfo.h PRE-CREATION 
>   refactoring/refactoringmanager.h PRE-CREATION 
>   refactoring/renamefielddeclrefactoring.h PRE-CREATION 
>   refactoring/renamefielddeclturefactoring.h PRE-CREATION 
>   refactoring/renamevardeclrefactoring.h PRE-CREATION 
>   refactoring/tudecldispatcher.h PRE-CREATION 
>   refactoring/tudecldispatcher.cpp PRE-CREATION 
>   tests/test_extractvariable.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124796/diff/
> 
> 
> Testing
> -------
> 
> One fix in tests which was lost in chains of rebases. Otherwise no tests.
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150817/2b34ba44/attachment.html>


More information about the KDevelop-devel mailing list