Review Request 124791: [kdevplatform/shell] Port AssistantPopup to QtQuick 2

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124791/#review83947
-----------------------------------------------------------


Note: Please check the behavior of that popup after the port. 

I did the same rough port a while ago and the popup just misbehaved (can't tell exactly how, but I think it caused flickering / unexpected hides, etc.)

- Kevin Funk


On Aug. 17, 2015, 2:21 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124791/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 2:21 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Code was ported because QtQuick 1 is deprecated.
> 
> The "patchreview" plugin that still needs to be ported.
> 
> 
> Diffs
> -----
> 
>   shell/AssistantButton.qml 586c1aa 
>   shell/CMakeLists.txt e52c4a7 
>   shell/assistantpopup.h bdf3317 
>   shell/assistantpopup.cpp 25afad5 
>   shell/assistantpopup.qml cc40a13 
> 
> Diff: https://git.reviewboard.kde.org/r/124791/diff/
> 
> 
> Testing
> -------
> 
> Only compilation tested.
> 
> Could someone please test this for regressions?
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150817/71b5c5ce/attachment.html>