Review Request 124735: Automatically change member access operator

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124735/#review83913
-----------------------------------------------------------

Ship it!



codecompletion/context.cpp (line 710)
<https://git.reviewboard.kde.org/r/124735/#comment58130>

    Do that just once, at the beginning of the ctor



duchain/clangdiagnosticevaluator.h (line 34)
<https://git.reviewboard.kde.org/r/124735/#comment58128>

    Perfect



duchain/clangdiagnosticevaluator.cpp (line 70)
<https://git.reviewboard.kde.org/r/124735/#comment58129>

    Something to keep in mind: All these checks in ClangDiangosticEvaluator could be done without converting the diagnostic string to a QString (-> heap alloc!). We could simply use QByteArray everywhere -> no conversions.
    
    (should be done in a follow-up patch if possible)



duchain/clangdiagnosticevaluator.cpp (line 115)
<https://git.reviewboard.kde.org/r/124735/#comment58127>

    Hm?


- Kevin Funk


On Aug. 15, 2015, 8:05 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124735/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2015, 8:05 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This automatically changes '.' to '->' and vice-versa, based on LibClang diagnostics.
>     
> Sadly, Clang doesn't provide the diagnostic when '.' is used instead of '->', so in that case automatic replacement doesn't work.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp db90f80 
>   duchain/clangdiagnosticevaluator.h 59e3af1 
>   duchain/clangdiagnosticevaluator.cpp 0f3e28b 
>   tests/test_codecompletion.h b0be470 
>   tests/test_codecompletion.cpp 0ea2572 
> 
> Diff: https://git.reviewboard.kde.org/r/124735/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150817/08d55c60/attachment.html>