Review Request 124735: Automatically change member access operator

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124735/#review83801
-----------------------------------------------------------


Nice idea!


codecompletion/context.cpp (line 631)
<https://git.reviewboard.kde.org/r/124735/#comment58032>

    If you Q_DECLARE_METATYPE/qRegisterMetaType Type, you can also use the type instead of 'int' here.



codecompletion/context.cpp (line 634)
<https://git.reviewboard.kde.org/r/124735/#comment58033>

    I think there's an 'activeDocument' function.



codecompletion/context.cpp (line 694)
<https://git.reviewboard.kde.org/r/124735/#comment58030>

    diagn -> diagnostic



codecompletion/context.cpp (line 699)
<https://git.reviewboard.kde.org/r/124735/#comment58029>

    This is the first thing I'd like to work on when having more time available again. Exposing an enumeration of those diagnostic message from libclang so we can finally react upon them without string comparisons...



codecompletion/context.cpp (line 704)
<https://git.reviewboard.kde.org/r/124735/#comment58031>

    Factor that check against the diagnostic string out.
    
    Hint: Go to ClangDiagnosticEvaluator, introduce `isReplaceWithDotProblem` + `isReplaceWithArrowProblem`.
    
    Better, so we can (potentially) port all the diagnostic evaluations later on


- Kevin Funk


On Aug. 14, 2015, 9:34 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124735/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2015, 9:34 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This automatically changes '.' to '->' and vice-versa, based on LibClang diagnostics.
>     
> Sadly, Clang doesn't provide the diagnostic when '.' is used instead of '->', so in that case automatic replacement doesn't work.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp db90f80 
>   tests/test_codecompletion.h b0be470 
>   tests/test_codecompletion.cpp 0ea2572 
> 
> Diff: https://git.reviewboard.kde.org/r/124735/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150814/c9ab2b6c/attachment-0001.html>