Review Request 124729: Handle closing "Refactoring..." dialog. Improve performance of RefactoringTool for single files
Maciej Poleski
d82ks8djf82msd83hf8sc02lqb5gh5 at gmail.com
Thu Aug 13 19:39:04 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124729/
-----------------------------------------------------------
Review request for KDevelop.
Repository: kdev-clang
Description
-------
Handle closing "Refactoring..." dialog. Interruption is not supported, but user can anyway close modal dialog. In such a case:
1) remain in "defined behavior" world
2) baheve as if refactoring was cancelled
Improve performance of RefactoringTool for single files. Uses find_buddy feature of `ClangSupport` (from interface). Get set of possible "buddy" files for given file, filter main TU files from them and make `RefactoringTool` with them registered as "SourcePaths". It can greatly improve performance of `RefactoringManager`. Even with very simple implementation of find_buddy, generated `RefactoringTool` will be efficient for `RefactoringManager` in the vast majority of source files.
Diffs
-----
refactoring/documentcache.cpp PRE-CREATION
refactoring/kdevrefactorings.h PRE-CREATION
refactoring/kdevrefactorings.cpp PRE-CREATION
refactoring/refactoring.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/124729/diff/
Testing
-------
Manual testing
Thanks,
Maciej Poleski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150813/db0c00a1/attachment-0001.html>
More information about the KDevelop-devel
mailing list