Review Request 124712: Set maximum number of recursive calls for getMemberFunctions.

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124712/#review83741
-----------------------------------------------------------


If that fixes the bug for you, cool! Unit tests would be nice, too, if you have the code snippet causing this.


languages/cpp/cppduchain/typeutils.h (line 108)
<https://git.reviewboard.kde.org/r/124712/#comment57955>

    Adhere to coding style, see below.



languages/cpp/cppduchain/typeutils.cpp (line 175)
<https://git.reviewboard.kde.org/r/124712/#comment57954>

    Coding style: 
    - do `a < b` (with spaces)
    - use camel-case (`recursionCount`)
    
    Also, please move the "max recursion count" constant to anonymous namespace or to the beginning of the function.
    
    I.e. at the beginning of the function, do
    
    ```
    static const int MaxRecursionCount = 50;
    ```


- Kevin Funk


On Aug. 12, 2015, 1:40 p.m., Zhang HuiJie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124712/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2015, 1:40 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=351188
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=351188
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> In some special case of curiously recurring template pattern(https://en.wikipedia.org/wiki/Curiously_recurring_template_pattern) for my codes(OpenFOAM-2.3.x), the oldcpp will get into an endless loop and breakdown finally.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/typeutils.h bab23f5 
>   languages/cpp/cppduchain/typeutils.cpp 4950981 
> 
> Diff: https://git.reviewboard.kde.org/r/124712/diff/
> 
> 
> Testing
> -------
> 
> I reported this bug(https://bugs.kde.org/show_bug.cgi?id=351188), but the report was not enough. After a few hours of hacking, kdevelop can work well for my codes. what's more, it seems that kdevelop run faster then before.
> 
> 
> Thanks,
> 
> Zhang HuiJie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150812/b21998bd/attachment.html>