Review Request 124631: Fix initialization of cache in RefactoringTool for single file
Milian Wolff
mail at milianw.de
Sun Aug 9 21:22:10 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124631/#review83628
-----------------------------------------------------------
Ship it!
refactoring/documentcache.cpp (line 86)
<https://git.reviewboard.kde.org/r/124631/#comment57873>
if (!textDocument)
- Milian Wolff
On Aug. 5, 2015, 8:56 p.m., Maciej Poleski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124631/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 8:56 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdev-clang
>
>
> Description
> -------
>
> Fix initialization of cache in RefactoringTool for single file.
>
> There was inappropriate initialization code for cache in single-file `RefactoringTool` - it initialized only the one file, but should everything.
>
>
> Diffs
> -----
>
> refactoring/documentcache.h PRE-CREATION
> refactoring/documentcache.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/124631/diff/
>
>
> Testing
> -------
>
> Manual testing. Bug occured during testing of Extract Function refactoring
>
>
> Thanks,
>
> Maciej Poleski
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150809/3cc6c1a4/attachment.html>
More information about the KDevelop-devel
mailing list