Review Request 124638: More tests for Extract Variable refactoring (extended capabilities from UTF)

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124638/#review83519
-----------------------------------------------------------

Ship it!


the tests are fine, but I wonder whether you could also test the higher-level integration. Conceptually, the user would select some range and then run one of a set of available refactoring actions. So could we get a test that takes code + range as input and then checks what refactoring actions are available and then runs them? Bypassing GUI should still be possible somehow, e.g. by casting the refactoring action to some concrete type and then calling a "doRefactor(variableName)" or similar on it.


tests/test_extractvariable.cpp (line 119)
<https://git.reviewboard.kde.org/r/124638/#comment57769>

    this is not a sum :)


- Milian Wolff


On Aug. 5, 2015, 11:42 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124638/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 11:42 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> More tests for Extract Variable refactoring (this time real tests)
> 
> Comes separately because UTF was extended during work on Extract Function which is after Extract Variable
> 
> 
> Diffs
> -----
> 
>   refactoring/extractvariablerefactoring.h PRE-CREATION 
>   refactoring/extractvariablerefactoring.cpp PRE-CREATION 
>   tests/test_extractvariable.h PRE-CREATION 
>   tests/test_extractvariable.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124638/diff/
> 
> 
> Testing
> -------
> 
> 4x PASS
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150806/1f81b799/attachment.html>