Review Request 124635: WIP: Add QmlConfigPage class

Sven Brauch mail at svenbrauch.de
Wed Aug 5 22:28:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124635/#review83470
-----------------------------------------------------------


Very nice idea, when I finally manage to get kdev-python working again at all I'll try porting its config pages to this, I'd be very happy to get rid of all the boilerplate code.


util/qmlconfigpage.cpp (line 88)
<https://git.reviewboard.kde.org/r/124635/#comment57698>

    i18n?


- Sven Brauch


On Aug. 5, 2015, 9:58 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124635/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 9:58 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> WIP: Add QmlConfigPage class
> 
> 
> Diffs
> -----
> 
>   util/qmlconfigpage.cpp PRE-CREATION 
>   util/qmlconfigpage.h PRE-CREATION 
>   util/CMakeLists.txt 6ce19e0ce73ce60ea77b7cbd47962423aa805fa7 
> 
> Diff: https://git.reviewboard.kde.org/r/124635/diff/
> 
> 
> Testing
> -------
> 
> Example implementation of the JSHint preferences page:
> 
> ```
> import QtQuick 2.2
> import QtQuick.Controls 1.2
> import QtQuick.Layouts 1.0
> 
> import org.kde.plasma.core 2.0 as PlasmaCore
> 
> Rectangle {
>     id: root
> 
>     readonly property string name: i18n("JSHint Config")
> 
>     property alias cfg_JSHintPath: jshintPath.text
> 
>     SystemPalette { id: sysPalette }
> 
>     color: sysPalette.window
> 
>     GroupBox {
>         width: parent.width
>         title: i18n("Paths")
> 
>         GridLayout {
>             id: gridLayout
> 
>             anchors.fill: parent
>             columns: 2
> 
>             Label { text: i18n("JSHint Executable:") }
>             TextField { id: jshintPath; Layout.fillWidth: true}
>         }
>     }
> }
> ```
> 
> Comments welcome.
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150805/69bc354a/attachment.html>


More information about the KDevelop-devel mailing list