Review Request 124598: Extract variable refactoring

[Kevin Funk]

> On Aug. 3, 2015, 12:01 p.m., Kevin Funk wrote:
> > refactoring/extractvariablerefactoring.h, line 45
> > <https://git.reviewboard.kde.org/r/124598/diff/1/?file=389508#file389508line45>
> >
> >     Initialize those here, they're not necessarily initialized after the ctor has run.
> 
> Maciej Poleski wrote:
>     but strings are anyway default constructed (used below)

I'm talking about the POD types


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124598/#review83377
-----------------------------------------------------------


On Aug. 3, 2015, 3:52 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124598/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2015, 3:52 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Extract variable refactoring
> 
> Select some expression, right click, [Extract variable], type name of new variable to create, enjoy
> 
> This is "local refactoring" - RefactoringContext is not used in `invoke` (thus it is fast)
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/contextmenumutator.cpp PRE-CREATION 
>   refactoring/error.h PRE-CREATION 
>   refactoring/error.cpp PRE-CREATION 
>   refactoring/extractvariablerefactoring.h PRE-CREATION 
>   refactoring/extractvariablerefactoring.cpp PRE-CREATION 
>   refactoring/refactoringcontext.h PRE-CREATION 
>   refactoring/refactoringcontext.cpp PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
>   tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
>   tests/test_extractvariable.h PRE-CREATION 
>   tests/test_extractvariable.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124598/diff/
> 
> 
> Testing
> -------
> 
> Tests included
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150803/61f5dd5b/attachment-0001.html>