Review Request 124598: Extract variable refactoring

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124598/#review83363
-----------------------------------------------------------


please add unit tests - I don't understand what is unclear when injecting precise source locations. I expect the test to give some before / after code with a range on which the refactoring action is run as well as an identifier for the expression variable.


refactoring/extractvariablerefactoring.h (line 41)
<https://git.reviewboard.kde.org/r/124598/#comment57608>

    what do you mean by the final comment?


- Milian Wolff


On Aug. 2, 2015, 10:40 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124598/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2015, 10:40 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Extract variable refactoring
> 
> Select some expression, right click, [Extract variable], type name of new variable to create, enjoy
> 
> This is "local refactoring" - RefactoringContext is not used in `invoke` (thus it is fast)
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/extractvariablerefactoring.h PRE-CREATION 
>   refactoring/extractvariablerefactoring.cpp PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124598/diff/
> 
> 
> Testing
> -------
> 
> Manual testing. Still unsure how to cleanly inject precise source locations:
> ```
> run(const std::string &filenameExpression,
>     const std::string &expression,
>     const std::string &filenameVariablePlacement,
>     const std::string &variableType,
>     const std::string &variableName,
>     const unsigned offsetExpression,
>     const unsigned lengthExpression,
>     const unsigned offsetVariablePlacement)
> ```
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150803/8cd16d5f/attachment.html>