Review Request 123562: Add outlineview plugin

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123562/#review79699
-----------------------------------------------------------



plugins/outlineview/outlinemodel.cpp (line 211)
<https://git.reviewboard.kde.org/r/123562/#comment54543>

    const&



plugins/outlineview/outlinemodel.cpp (line 218)
<https://git.reviewboard.kde.org/r/123562/#comment54544>

    remove parameter
    
    DUCRL lock;
    
    also, I'd use a scope again instead of calling unlock manually



plugins/outlineview/outlinemodel.cpp (line 228)
<https://git.reviewboard.kde.org/r/123562/#comment54546>

    replace with
    
        Q_ASSERT(decl->url().toUrl() == m_doc->url());



plugins/outlineview/outlinemodel.cpp (line 233)
<https://git.reviewboard.kde.org/r/123562/#comment54545>

    couldn't you use m_doc here?



plugins/outlineview/outlinenode.h (line 34)
<https://git.reviewboard.kde.org/r/123562/#comment54547>

    why?



plugins/outlineview/outlinenode.cpp (line 38)
<https://git.reviewboard.kde.org/r/123562/#comment54548>

    split on two lines



plugins/outlineview/outlineproxymodel.cpp (line 36)
<https://git.reviewboard.kde.org/r/123562/#comment54549>

    this sounds like you are reimplementing KRecursiveFilterProxyModel - could that be the case? please use that instead


- Milian Wolff


On April 29, 2015, 8:01 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123562/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 8:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This plugin provides an outline view for the current document. It is
> very similar to the outline view from eclipse and should also work for
> any language.
> 
> I initially wrote this plugin in 2010 and then forgot about it. I've now
> ported it to KF5 and it seems to work without any major issues. The only
> major thing that is missing is that it updates once the document has been
> reparsed and not whenever it is saved.
> 
> 
> Diffs
> -----
> 
>   plugins/CMakeLists.txt 2c004f22976f513eab607762b4e04fc1b5b048fa 
>   plugins/outlineview/CMakeLists.txt PRE-CREATION 
>   plugins/outlineview/debug_outline.h PRE-CREATION 
>   plugins/outlineview/kdevoutlineview.json PRE-CREATION 
>   plugins/outlineview/outlinemodel.h PRE-CREATION 
>   plugins/outlineview/outlinemodel.cpp PRE-CREATION 
>   plugins/outlineview/outlinenode.h PRE-CREATION 
>   plugins/outlineview/outlinenode.cpp PRE-CREATION 
>   plugins/outlineview/outlineproxymodel.h PRE-CREATION 
>   plugins/outlineview/outlineproxymodel.cpp PRE-CREATION 
>   plugins/outlineview/outlineviewplugin.h PRE-CREATION 
>   plugins/outlineview/outlineviewplugin.cpp PRE-CREATION 
>   plugins/outlineview/outlinewidget.h PRE-CREATION 
>   plugins/outlineview/outlinewidget.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123562/diff/
> 
> 
> Testing
> -------
> 
> works without crashes sofar.
> 
> Is sometimes empty initially, switching to other document and back fixes that
> 
> 
> File Attachments
> ----------------
> 
> outline1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/08b90a88-1cbf-4f98-94e8-d7ea1ad02586__outline1.png
> outline2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/d8ee18c4-495a-44db-a346-803389462c42__outline2.png
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150429/d1376e57/attachment-0001.html>