Review Request 123563: WIP: Allow using eclipse style icons

Alex Richardson arichardson.kde at gmail.com
Wed Apr 29 20:39:52 UTC 2015 


> On April 29, 2015, 2:49 p.m., Milian Wolff wrote:
> > nice, I can see people who'd use this (not me though, I'd rather ask the VDG to improve our icons :P).
> > 
> > there are some style issues with the code, could you fix this?
> 
> Milian Wolff wrote:
>     One thing I forgot to mention: You are missing a COPYING or similar file that gives the license of the icons.

The icons are licensed under the EPL. I did a bit of research and it seems that GPL and EPL are incompatible (although LGPL works). Now all that was talking about linking so I have no idea how that relates to icons... I don't understand the license so I guess I will have to contact someone from Eclipse to figure out whether this is possible.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123563/#review79681
-----------------------------------------------------------


On April 29, 2015, 1:56 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123563/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 1:56 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> I personally find them a lot more intuitive than the Visual Studio ones that
> KDevelop ships (C = class, U = Union, S = Struct, T = typedef and N = namespace).
> I still had an old branch that replaced the KDevelop icons from a few years ago.
> I now cleaned it up and added them as an additional option besides the existing
> icon set. It is configurable at runtime but might take a while until all currently
> displayed icons have been updated.
> 
> 
> Diffs
> -----
> 
>   interfaces/icompletionsettings.h 4b95c5184cf3b950907f291986a1efa2ad48d032 
>   language/duchain/duchainutils.h 7d4760af955f37c0ad87f4635ddaa8ce31eb445b 
>   language/duchain/duchainutils.cpp 8a26194dcadeb98c94785fecd1b69c91ca0b4502 
>   pics/CMakeLists.txt 6e046c7fcb5eb29a6c3331c13cdbeff992946a8a 
>   pics/codecompletion/CMakeLists.txt PRE-CREATION 
>   pics/codecompletion/eclipse_class.png PRE-CREATION 
>   pics/codecompletion/eclipse_class_forward.png PRE-CREATION 
>   pics/codecompletion/eclipse_class_package.png PRE-CREATION 
>   pics/codecompletion/eclipse_class_private.png PRE-CREATION 
>   pics/codecompletion/eclipse_class_protected.png PRE-CREATION 
>   pics/codecompletion/eclipse_class_public.png PRE-CREATION 
>   pics/codecompletion/eclipse_define.png PRE-CREATION 
>   pics/codecompletion/eclipse_enum.png PRE-CREATION 
>   pics/codecompletion/eclipse_enum_forward.png PRE-CREATION 
>   pics/codecompletion/eclipse_enumerator.png PRE-CREATION 
>   pics/codecompletion/eclipse_field_package.png PRE-CREATION 
>   pics/codecompletion/eclipse_field_private.png PRE-CREATION 
>   pics/codecompletion/eclipse_field_protected.png PRE-CREATION 
>   pics/codecompletion/eclipse_field_public.png PRE-CREATION 
>   pics/codecompletion/eclipse_function_global.png PRE-CREATION 
>   pics/codecompletion/eclipse_function_package.png PRE-CREATION 
>   pics/codecompletion/eclipse_function_private.png PRE-CREATION 
>   pics/codecompletion/eclipse_function_protected.png PRE-CREATION 
>   pics/codecompletion/eclipse_function_public.png PRE-CREATION 
>   pics/codecompletion/eclipse_global_function_declaration.png PRE-CREATION 
>   pics/codecompletion/eclipse_implement.png PRE-CREATION 
>   pics/codecompletion/eclipse_interface.png PRE-CREATION 
>   pics/codecompletion/eclipse_interface_forward.png PRE-CREATION 
>   pics/codecompletion/eclipse_namespace.png PRE-CREATION 
>   pics/codecompletion/eclipse_overlay_abstract.png PRE-CREATION 
>   pics/codecompletion/eclipse_overlay_const.png PRE-CREATION 
>   pics/codecompletion/eclipse_overlay_implement.png PRE-CREATION 
>   pics/codecompletion/eclipse_overlay_override.png PRE-CREATION 
>   pics/codecompletion/eclipse_overlay_package_access.png PRE-CREATION 
>   pics/codecompletion/eclipse_overlay_private.png PRE-CREATION 
>   pics/codecompletion/eclipse_overlay_protected.png PRE-CREATION 
>   pics/codecompletion/eclipse_overlay_public.png PRE-CREATION 
>   pics/codecompletion/eclipse_overlay_static.png PRE-CREATION 
>   pics/codecompletion/eclipse_overlay_virtual.png PRE-CREATION 
>   pics/codecompletion/eclipse_override.png PRE-CREATION 
>   pics/codecompletion/eclipse_shadows.png PRE-CREATION 
>   pics/codecompletion/eclipse_struct.png PRE-CREATION 
>   pics/codecompletion/eclipse_struct_forward.png PRE-CREATION 
>   pics/codecompletion/eclipse_type_variable.png PRE-CREATION 
>   pics/codecompletion/eclipse_typedef.png PRE-CREATION 
>   pics/codecompletion/eclipse_typedef_forward.png PRE-CREATION 
>   pics/codecompletion/eclipse_union.png PRE-CREATION 
>   pics/codecompletion/eclipse_union_forward.png PRE-CREATION 
>   pics/codecompletion/eclipse_unknown_type.png PRE-CREATION 
>   pics/codecompletion/eclipse_unknown_type_2.png PRE-CREATION 
>   pics/codecompletion/eclipse_using.png PRE-CREATION 
>   pics/codecompletion/eclipse_variable_declaration.png PRE-CREATION 
>   pics/codecompletion/eclipse_variable_global.png PRE-CREATION 
>   pics/codecompletion/eclipse_variable_local.png PRE-CREATION 
>   pics/codecompletion/eclipse_variable_type.png PRE-CREATION 
>   shell/completionsettings.h 05f166b4323c773c38ceb6703f36aabe35900636 
>   shell/completionsettings.cpp 89cf68b46e312e0a54cd67cf7235ff5930833f82 
>   shell/settings/ccconfig.kcfg 624d8da97580266f52220258e7aa42e0067e76a3 
>   shell/settings/ccpreferences.cpp 9346e2397ea4225f9bde02ab4c30889ab0732d24 
>   shell/settings/ccpreferences.ui 48bd90f44f670b5ea879bc6b187ead8c9bcbba30 
> 
> Diff: https://git.reviewboard.kde.org/r/123563/diff/
> 
> 
> Testing
> -------
> 
> Icons are loaded, switching between themes also works
> 
> Examples below are from the outline view plugin (https://git.reviewboard.kde.org/r/123562/)
> 
> 
> File Attachments
> ----------------
> 
> eclipse_icons1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/91b275a1-006e-4752-a322-2404cf674595__eclipse_icons1.png
> eclipse_icons2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/d365bd2b-20a5-4b8f-9743-84efbf552577__eclipse_icons2.png
> eclipse_icons3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/ef3ecddd-2a0e-40d1-acd4-db105d2e3748__eclipse_icons3.png
> eclipse_icons4.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/b22651f8-f260-467a-85b6-36592f7176fd__eclipse_icons4.png
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150429/bf070c0c/attachment.html>

More information about the KDevelop-devel mailing list