Review Request 123564: Add Macro as a new Declaration::Kind and add code completion properties

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123564/#review79684
-----------------------------------------------------------

Ship it!


I'd commit this as-is and put the icon into the eclipse patch to not be blocked on that

- Milian Wolff


On April 29, 2015, 12:56 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123564/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 12:56 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> kdev-clang has the class MacroDeclaration so once it has been changed
> to call setKind(Declaration::Macro) macros will have correct icons in
> the outline view
> 
> 
> Diffs
> -----
> 
>   language/duchain/declaration.h 95b7630c559a7e561704f7a189ee2dcdc8e38beb 
>   language/duchain/duchainutils.cpp 8a26194dcadeb98c94785fecd1b69c91ca0b4502 
>   pics/codecompletion/CMakeLists.txt PRE-CREATION 
>   pics/codecompletion/eclipse_define.png PRE-CREATION 
>   tests/json/jsondeclarationtests.h 3ae82c0b0e795a6a6f4abe0adfdf90e9068a0487 
> 
> Diff: https://git.reviewboard.kde.org/r/123564/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150429/b16a5b49/attachment.html>