Review Request 123566: Make sure macros have the right icon in code completion and outline

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123566/#review79683
-----------------------------------------------------------

Ship it!


nice!


codecompletion/context.cpp (line 241)
<https://git.reviewboard.kde.org/r/123566/#comment54534>

    put on its own line please



codecompletion/context.cpp (line 252)
<https://git.reviewboard.kde.org/r/123566/#comment54535>

    merge the two ifs
    
    if (role == ... && index.column() == )


- Milian Wolff


On April 29, 2015, 12:57 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123566/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 12:57 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Make sure macros have the right icon in code completion and outline
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp c6e49aad2e6d06b8acce069aca5edf592782204a 
>   duchain/macrodefinition.cpp 977a3ba098fa862bfd46a8b5530527408cda0275 
> 
> Diff: https://git.reviewboard.kde.org/r/123566/diff/
> 
> 
> Testing
> -------
> 
> Icon is displayed correctly
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150429/7c40ada1/attachment.html>