Review Request 123507: Fix compilation error in kdev-clang declaring types for Qt

Milian Wolff mail at milianw.de
Sun Apr 26 13:09:36 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123507/#review79532
-----------------------------------------------------------


If at all, you'll have to add macro guards around it to make it still work fine with current kf5 ktexteditor framework from git (and all upcoming releases). My personal preference would be to increase our kf5 dependency to make clear we require a new version.

- Milian Wolff


On April 26, 2015, 12:34 p.m., Lucas Tanure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123507/
> -----------------------------------------------------------
> 
> (Updated April 26, 2015, 12:34 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Error: kdev-clang doesn't compile
> 
> 
> Diffs
> -----
> 
>   tests/test_duchainutils.cpp 7393587 
>   tests/test_clangutils.cpp fb33f76 
>   codecompletion/model.cpp 0dcf44c 
> 
> Diff: https://git.reviewboard.kde.org/r/123507/diff/
> 
> 
> Testing
> -------
> 
> Adding a Q_DECLARE_METATYPE() makes the type known to all template based functions, including QVariant.
> So we need to declare "KTextEditor::Cursor" and "KTextEditor::Range" to proper compile kdev-clang.
> 
> 
> Thanks,
> 
> Lucas Tanure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150426/dc04f8a6/attachment.html>


More information about the KDevelop-devel mailing list