Review Request 123279: Add color tab feature

Sebastien Speierer sspeiere at andrew.cmu.edu
Thu Apr 23 19:43:36 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123279/
-----------------------------------------------------------

(Updated April 23, 2015, 7:43 p.m.)


Review request for KDevelop.


Changes
-------

In this implementation, when the feature is disable it set the correct color scheme in the case where the user has a non-grey background color for the tabs.


Repository: kdevplatform


Description
-------

This patch adds a checkbox in the KDevelop setting that allows KDevelop to color the tabs (of the open files) depending of their project.
This feature was asked by several users on the KDE bugtracking system.


Diffs (updated)
-----

  .kateproject.d/notes.txt PRE-CREATION 
  shell/mainwindow.h ae22648 
  shell/mainwindow.cpp 8757942 
  shell/project.cpp e7e6efa 
  shell/settings/uiconfig.kcfg b168294 
  shell/settings/uiconfig.ui a0d76de 
  shell/uicontroller.cpp 2108ff2 
  sublime/container.h 9049f55 
  sublime/container.cpp 4444077 
  sublime/urldocument.h 4a02d89 

Diff: https://git.reviewboard.kde.org/r/123279/diff/


Testing
-------

I tested the feature (open file before/after enable the coloring, tried to open files from several different projects,...), the implementation seems robust.


File Attachments
----------------

Screenshot01
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/22/c544c7ee-765e-4851-be5c-86d5b2241dab__kdevelop5_env_1.png


Thanks,

Sebastien Speierer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150423/380d25fa/attachment.html>


More information about the KDevelop-devel mailing list