Review Request 122160: Use buddy as fallback for headers without explicitly pinned TU.

Milian Wolff mail at milianw.de
Tue Apr 21 18:59:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122160/
-----------------------------------------------------------

(Updated April 21, 2015, 6:59 p.m.)


Review request for KDevelop.


Summary (updated)
-----------------

Use buddy as fallback for headers without explicitly pinned TU.


Repository: kdev-clang


Description (updated)
-------

In such cases, it's worthwile to use the source buddy as best-guess as
it allows us to get rid of the parse run for the "header TU" which
gets thrown away later on anyways.

Performance wise, this patch improves the index run on a 48 file
project using STL: It goes from ~17s down to ~14s, just b/c we safe
a few needless clang runs on "header TUs".

REVIEW: 122160


Diffs (updated)
-----

  CMakeLists.txt a28f0c1925bf20bfbde22e4dc0fd702960f4e3cd 
  clangparsejob.cpp d4c24d314598a17e043c4427d1781f6d7551b6a5 
  clangsupport.cpp f2c1a1ac7a0a366e698ae836954b397a95015ecc 
  documentfinderhelpers.h  
  documentfinderhelpers.cpp  
  duchain/CMakeLists.txt 8ed282b652361c45c668fa948917e075fed4f277 
  duchain/clangindex.cpp 25c7855e7bd67aa2a3be28f1ea803dd025e6a1ba 

Diff: https://git.reviewboard.kde.org/r/122160/diff/


Testing
-------


Thanks,

Milian Wolff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150421/74810b5d/attachment.html>


More information about the KDevelop-devel mailing list