Review Request 122658: Adds ClangFormat to kdevcustomscript_plugin

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122658/#review78728
-----------------------------------------------------------



formatters/customscript/customscript_plugin.cpp (line 161)
<https://git.reviewboard.kde.org/r/122658/#comment53867>

    Makes sure to not add any empty whitespace (here and below in your patch)



formatters/customscript/customscript_plugin.cpp (line 162)
<https://git.reviewboard.kde.org/r/122658/#comment53869>

    Use camelCasing instead => `workingDir` or sth.



formatters/customscript/customscript_plugin.cpp (line 164)
<https://git.reviewboard.kde.org/r/122658/#comment53868>

    Use `str.isEmpty()`



formatters/customscript/customscript_plugin.cpp (line 277)
<https://git.reviewboard.kde.org/r/122658/#comment53870>

    Less indentation -- just use 4 chars more than 'result' from the above line.



formatters/customscript/customscript_plugin.cpp (line 607)
<https://git.reviewboard.kde.org/r/122658/#comment53871>

    Remove WS


Please fix the outstanding issues then this is good to go I think. 

Thanks!

- Kevin Funk


On March 4, 2015, 12:43 a.m., Mario Bielert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122658/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 12:43 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This patch adds ClangFormat as a predefinded style to customscript_plugin formatter
> 
> 
> Diffs
> -----
> 
>   formatters/customscript/customscript_plugin.cpp 8e2e6bb 
> 
> Diff: https://git.reviewboard.kde.org/r/122658/diff/
> 
> 
> Testing
> -------
> 
> Not much testing required, as it's just a few lines adding the command line and a name.
> 
> 
> Thanks,
> 
> Mario Bielert
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150409/a1eafd9a/attachment.html>