Review Request 122840: custom-definesandincludes: don't crash on the configuration after pressing Apply
Miquel Sabaté Solà
mikisabate at gmail.com
Sun Apr 5 07:01:56 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122840/
-----------------------------------------------------------
(Updated April 5, 2015, 7:01 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDevelop.
Changes
-------
Submitted with commit 5c2ad34f560c96bf291639d874a0d2b78960a8a3 by Sergey Kalinichev to branch master.
Repository: kdevelop
Description
-------
I haven't touched the "Compilers" tab, so maybe this is why I'm getting this assert all the time. In this patch I've replaced the assert with a good ol'
```cpp
if (!compiler) {
```
Since this is an assert, I wanted to check this here first before pushing or anything :)
Diffs
-----
languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp df2c425
Diff: https://git.reviewboard.kde.org/r/122840/diff/
Testing
-------
manual testing
Thanks,
Miquel Sabaté Solà
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150405/bb1d3bdd/attachment.html>
More information about the KDevelop-devel
mailing list