Review Request 120312: Port .cpp files from KDELibs4Support

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120312/#review67735
-----------------------------------------------------------

Ship it!


Rest looks good to me. Feel free to commit after that.

Btw, would be cool if you could join us on IRC (#kdevelop, Freenode) for quicker communication.


CMakeLists.txt
<https://git.reviewboard.kde.org/r/120312/#comment47190>

    You can now use 'KDev::Serialization'. I've fixed the issue in kdevplatform. Sorry for that :)



uploadjob.cpp
<https://git.reviewboard.kde.org/r/120312/#comment47187>

    Style: 
    ```
    if (foo) {
        stmt;
    } else {
        stmt;
    }
    ```



uploadprofiledlg.cpp
<https://git.reviewboard.kde.org/r/120312/#comment47188>

    Create on the stack.


- Kevin Funk


On Sept. 30, 2014, 8:47 p.m., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120312/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 8:47 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-upload
> 
> 
> Description
> -------
> 
> Mostly simple KUrl->QUrl changes with just a few harder corners like porting to QDialog or KUrl::relativePath(...). Removing KDELibs4support from CMakeList.txt is impossible now as KDevPlatform code depends on it.
> 
> 
> Diffs
> -----
> 
>   uploadprofilemodel.cpp 16847b2 
>   uploadprojectmodel.h 8379810 
>   uploadprojectmodel.cpp 30db851 
>   uploadprofiledlg.cpp ff234bd 
>   uploadprofileitem.h b17187a 
>   uploadprofileitem.cpp ee4610e 
>   uploadpreferences.ui ac4c679 
>   uploadprofiledlg.h d363190 
>   uploadjob.cpp c58db45 
>   uploadpreferences.cpp 0949c92 
>   profilesfiletree.cpp 2c19df0 
>   tests/CMakeLists.txt f4bc1a8 
>   tests/permissions.cpp 8735c8d 
>   CMakeLists.txt 3428c80 
>   kdevuploadplugin.cpp 5261978 
>   profilesfiletree.h c595f32 
> 
> Diff: https://git.reviewboard.kde.org/r/120312/diff/
> 
> 
> Testing
> -------
> 
> Code compiles and works with no regressions I could find right.
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140930/a9267590/attachment-0001.html>