Review Request 120373: Port all CMake and source files to the new Grantlee5 library
Simon Wächter
waechter.simon at gmail.com
Fri Sep 26 05:26:05 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120373/
-----------------------------------------------------------
(Updated Sept. 26, 2014, 7:26 vorm.)
Review request for KDevelop and Kevin Funk.
Changes
-------
Fixed the issue
Repository: kdevplatform
Description
-------
A previous commit broke the build process if Grantlee5 is available. This patch updates all CMake files to the new syntax and variables. Also the Grantlee Ptr class was removed and should be replaced with a QSharedPointer.
Diffs (updated)
-----
CMakeLists.txt 903e4a0
language/CMakeLists.txt 6a3a29f
language/codegen/templateengine.cpp 991eb1e
plugins/CMakeLists.txt 2497765
template/CMakeLists.txt a35d2cd
Diff: https://git.reviewboard.kde.org/r/120373/diff/
Testing
-------
Testing was done under a project neon 5 system:
- With installed cmake, includes and libraries
- Without cmake, includes and libraries
Both situations works. Further testing (just to be sure) is welcomed.
Thanks,
Simon Wächter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140926/9bc58f5d/attachment-0001.html>
More information about the KDevelop-devel
mailing list