Review Request 120367: replace export headers w. generate_export_headers

Kevin Funk kfunk at kde.org
Thu Sep 25 16:13:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120367/#review67436
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Funk


On Sept. 25, 2014, 2:13 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120367/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2014, 2:13 p.m.)
> 
> 
> Review request for KDevelop, kdewin, Milian Wolff, and Niko Sams.
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> replace export headers w. generate_export_headers
> 
> the include_directories are needed because it isn't possible to reference the build directory from inside the source files.
> 
> 
> Diffs
> -----
> 
>   duchain/CMakeLists.txt d57c45224fe3d5ece78ac432489becd1b3d1ce02 
>   completion/CMakeLists.txt e68290b59acf5882d315d44da117ca66778fac02 
>   completion/phpcompletionexport.h 5958009d3429a8154f26c37b10b0ea4521f71a54 
>   completion/tests/CMakeLists.txt 749ae72e0c1932a5d502b29a957daa9aef8c54e6 
>   parser/CMakeLists.txt d658dff79e8a536015def29077fafeed1aae72e3 
>   parser/parserexport.h 42820da8f22ca4b127e64bf8288af645af10ed83 
>   duchain/navigation/navigationwidget.h 56b4dc3d66b1660d9d23cfe47eac02a40cfdc3ad 
>   duchain/phpduchainexport.h 0b8328239d768dbf5e898e8e5c3b9037b88ba08b 
>   duchain/tests/CMakeLists.txt 524466d985a4fe0c80e4c1315c34258eb3cd976e 
> 
> Diff: https://git.reviewboard.kde.org/r/120367/diff/
> 
> 
> Testing
> -------
> 
> windows msvc 2013
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140925/90d3c961/attachment.html>


More information about the KDevelop-devel mailing list