Review Request 120312: Port .cpp files from KDELibs4Support

[Jakub Caban]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120312/
-----------------------------------------------------------

(Updated Sept. 23, 2014, 9:20 p.m.)


Review request for KDevelop.


Changes
-------

Port away from deprecated KDevPlatform methods. In the meantime lear how awesome KDevelop::Path is and use where relevant for now.


Repository: kdev-upload


Description
-------

Mostly simple KUrl->QUrl changes with just a few harder corners like porting to QDialog or KUrl::relativePath(...). Removing KDELibs4support from CMakeList.txt is impossible now as some weird dependency forces profile dialog to link against it. Probably something with .ui files? I will investigate when we'll have this part done.


Diffs (updated)
-----

  CMakeLists.txt 3428c80 
  kdevuploadplugin.cpp 5261978 
  profilesfiletree.h c595f32 
  profilesfiletree.cpp 2c19df0 
  uploadjob.cpp c58db45 
  uploadpreferences.cpp 0949c92 
  uploadprojectmodel.cpp 30db851 

Diff: https://git.reviewboard.kde.org/r/120312/diff/


Testing
-------

Code compiles and works with 2 regressions:
- Directory chooser for profile settings always opens user home folder instead of remote view
- upload job always reports 'Upload cancelled' even after succesfull upload


Thanks,

Jakub Caban

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140923/aa4be01f/attachment.html>