Review Request 120312: Port .cpp files from KDELibs4Support

[Jakub Caban]

> On Sept. 22, 2014, 12:55 p.m., Aleix Pol Gonzalez wrote:
> > tests/permissions.cpp, line 21
> > <https://git.reviewboard.kde.org/r/120312/diff/2/?file=314364#file314364line21>
> >
> >     You probably want QUrl::fromLocalInput()

This change was more like find and replace remaining KUrl references as for now I couldn't port this file - it seems only way to do so would be by writing it from scratch, so "tests" directory is commented out for now i CMakeList (yes, permissions.cpp is the only file in this dir).

I will surely come back to that later on, but I have to make everything in smaller steps to learn little bit with every progress.


- Jakub


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120312/#review67193
-----------------------------------------------------------


On Sept. 21, 2014, 10:30 p.m., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120312/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2014, 10:30 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-upload
> 
> 
> Description
> -------
> 
> Mostly simple KUrl->QUrl changes with just a few harder corners like porting to QDialog or KUrl::relativePath(...). Removing KDELibs4support from CMakeList.txt is impossible now as some weird dependency forces profile dialog to link against it. Probably something with .ui files? I will investigate when we'll have this part done.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3428c80 
>   profilesfiletree.h c595f32 
>   profilesfiletree.cpp 2c19df0 
>   tests/permissions.cpp 8735c8d 
>   uploadjob.cpp c58db45 
>   uploadpreferences.ui ac4c679 
>   uploadprofiledlg.h d363190 
>   uploadprofiledlg.cpp ff234bd 
>   uploadprofileitem.h b17187a 
>   uploadprofileitem.cpp ee4610e 
>   uploadprofilemodel.cpp 16847b2 
>   uploadprojectmodel.h 8379810 
>   uploadprojectmodel.cpp 30db851 
> 
> Diff: https://git.reviewboard.kde.org/r/120312/diff/
> 
> 
> Testing
> -------
> 
> Code compiles and works with 2 regressions:
> - Directory chooser for profile settings always opens user home folder instead of remote view
> - upload job always reports 'Upload cancelled' even after succesfull upload
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140922/f633328d/attachment.html>