Review Request 120317: WIP: Config pages without KCMs

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120317/
-----------------------------------------------------------

Review request for KDevelop.


Repository: kdevplatform


Description
-------

I only converted the UISettings to the new type for now, will convert the rest if this approach seems sensible

Editor pages are also added to the main config dialog.


Diffs
-----

  CMakeLists.txt 7da5c922f54cad7aafc2452f609ff172fc2214b7 
  interfaces/CMakeLists.txt 87916216011e4390ba9b637f9ae22fe54f254e86 
  interfaces/configpage.h PRE-CREATION 
  interfaces/configpage.cpp PRE-CREATION 
  interfaces/iplugin.h b101ae46fa430101c21a1c8eb8699674cbb1977b 
  interfaces/iplugin.cpp 1a0677312485ae47747cc3483ce325fe9890af78 
  shell/CMakeLists.txt 7847e261f53e4831f7dd662add34a6e6281d5cd4 
  shell/settings/CMakeLists.txt 5760ab4cb6a459ec6f1282ae09bb95f5f6e77892 
  shell/settings/uipreferences.h 34c46f3902cf06156c7f8279e6672ebb7a06a31e 
  shell/settings/uipreferences.cpp c8ba26201516241e29f76db4c6e448de787c4704 
  shell/uicontroller.h 797fa198ed17608e88f2a9e9a03f8072c5ebf45d 
  shell/uicontroller.cpp 0eab47ae515f7832ea8b1833252346cec84c8254 
  util/CMakeLists.txt 96b74b1a22f386f8dc120cebd5924eb37559e47b 
  util/configdialog.h PRE-CREATION 
  util/configdialog.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120317/diff/


Testing
-------

Dialog is shown correctly, apply, okay work correctly.

However when I change the dock position it is only changed in the GUI on the first save, later saves are ignored. Will have to investigate what's going wrong there.

Not sure why the first title is translated, AFAIK I don't have any KF5 translations installed (but maybe it loads it from my KDE4 installation?)


File Attachments
----------------

kdev_config_new.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/09/22/7e219540-1632-4465-9675-ad24a2fde56c__kdev_config_new.png


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140922/6a4691f2/attachment-0001.html>