Review Request 120312: Port .cpp files from KDELibs4Support

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120312/#review67193
-----------------------------------------------------------



tests/permissions.cpp
<https://git.reviewboard.kde.org/r/120312/#comment46894>

    You probably want QUrl::fromLocalInput()



uploadjob.cpp
<https://git.reviewboard.kde.org/r/120312/#comment46892>

    what if m_project->folder() is not a local URL?


In general you don't want to use QUrl::path. At least, toLocalPath, and only when you know it's local. If it's just about displaying relative urls, you can consider showing the full path for now and get rid of the path handling.

Regarding your linking problem, consider pasting here the error so we can work out what's wrong.

- Aleix Pol Gonzalez


On Sept. 21, 2014, 10:30 p.m., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120312/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2014, 10:30 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-upload
> 
> 
> Description
> -------
> 
> Mostly simple KUrl->QUrl changes with just a few harder corners like porting to QDialog or KUrl::relativePath(...). Removing KDELibs4support from CMakeList.txt is impossible now as some weird dependency forces profile dialog to link against it. Probably something with .ui files? I will investigate when we'll have this part done.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3428c80 
>   profilesfiletree.h c595f32 
>   profilesfiletree.cpp 2c19df0 
>   tests/permissions.cpp 8735c8d 
>   uploadjob.cpp c58db45 
>   uploadpreferences.ui ac4c679 
>   uploadprofiledlg.h d363190 
>   uploadprofiledlg.cpp ff234bd 
>   uploadprofileitem.h b17187a 
>   uploadprofileitem.cpp ee4610e 
>   uploadprofilemodel.cpp 16847b2 
>   uploadprojectmodel.h 8379810 
>   uploadprojectmodel.cpp 30db851 
> 
> Diff: https://git.reviewboard.kde.org/r/120312/diff/
> 
> 
> Testing
> -------
> 
> Code compiles and works with 2 regressions:
> - Directory chooser for profile settings always opens user home folder instead of remote view
> - upload job always reports 'Upload cancelled' even after succesfull upload
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140922/b92c57f5/attachment.html>