Review Request 120273: Initial work on porting to Frameworks

[Jakub Caban]

> On Sept. 19, 2014, 8:39 p.m., Jakub Caban wrote:
> > I actually found out KDevUpload doesn't even load due to 'missing shared library'. The cause of this is probably wrong install path. I found out cpp plugin from KDevelop is installed into:
> > 
> > /lib64/qt5/plugins/
> > 
> > But kdevupload into:
> > 
> > /usr/lib64/plugins/
> > 
> > Even though they both use ${PLUGIN_INSTALL_DIR} as their taget. could someone please hint me how to fix it? Couldn't solve it myself by looking at KDevelop code nor googling.
> > 
> > I am building with -DCMAKE_INSTALL_PREFIX=/usr - can that be source of the problem? What should I use intead to get going?
> 
> Milian Wolff wrote:
>     What shared library is missing?
> 
> Jakub Caban wrote:
>     kdevelop output:
>     kdevplatform (shell): Failed to load "KDevUpload" - "The shared library was not found."
>     kdevplatform (shell): Loading plugin ' "KDevUpload" ' failed.
>     
>     Probably it's about kdevupload.so as it's the only relevant file installed, but I don't know how to check deeper.
> 
> Sven Brauch wrote:
>     Just for the record, with master I have the same problem with all plugins and wasn't able to fix it so far. Maybe a wider issue?
> 
> Milian Wolff wrote:
>     probably fall-out from the recent patch to get away from .desktop files to .json files. Maybe there was a regression with the fallback mode that still relies on .desktop? Just for the record, X-KDE-Library should say "kdevupload" and that  should then be used by our plugincontroller to load the plugin (called kdevupload.so).
>     
>     bye
> 
> Jakub Caban wrote:
>     X-KDE-Library says kdevupload in intalled .desktop, so everything seems right at this side.
> 
> Alexander Richardson wrote:
>     Seems right to me, is the install dir (/usr/lib64/plugins) part of QT_PLUGIN_PATH?
> 
> Jakub Caban wrote:
>     Seems like it is:
>     
>     lustmored at vindor ~ $ echo $QT_PLUGIN_PATH
>     /usr/lib64/kde4/plugins:/usr/lib64/plugins:/usr/lib64/qt5/plugins
> 
> Alexander Richardson wrote:
>     Strange, I will test this once I get to my development PC today (~2 hours)
> 
> Alexander Richardson wrote:
>     The problem is that X-KDE-Library says "libkdevupload" but the plugin is installed as kdevupload.so, X-KDE-Library=kdevupload will fix the loading.
>     
>     Probably it used to have the lib prefix with the KDE4 build system.

Of course you are right. Plugin now loads - will update review request when I will hunt crashes.


- Jakub


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120273/#review66994
-----------------------------------------------------------


On Sept. 19, 2014, 9:26 p.m., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120273/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 9:26 p.m.)
> 
> 
> Review request for KDevelop and Alexander Richardson.
> 
> 
> Repository: kdev-upload
> 
> 
> Description
> -------
> 
> I have ported CMakeList to ECM and Framework based and ported as much source code as I could to compile agains KDevelop and KDevplatform master.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8e6baa4 
>   kdevuploadplugin.h 335b2b3 
>   kdevuploadplugin.cpp c805255 
>   profilesfiletree.h 4718b1e 
>   profilesfiletree.cpp fffe74e 
>   tests/CMakeLists.txt bb4f2f6 
>   uploaddialog.cpp 0600a7d 
>   uploadjob.cpp b48e58c 
>   uploadpreferences.cpp 4b4380e 
>   uploadprofiledlg.cpp 930f1c1 
>   uploadprofilemodel.cpp 84e8a79 
>   uploadprojectmodel.cpp 900b8d0 
> 
> Diff: https://git.reviewboard.kde.org/r/120273/diff/
> 
> 
> Testing
> -------
> 
> It compiles and allows to modify and add/delete upload profiles without crashing.
> 
> Missing bits:
> - options to Upload and Quick upload in file tree,
> - remote view (a.k.a. Upload Profiles toolbar),
> - testing if it will actually upload anything.
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140921/00fa992f/attachment.html>