Review Request 120273: Initial work on porting to Frameworks

Jakub Caban kuba at whyblack.pl
Fri Sep 19 19:57:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120273/
-----------------------------------------------------------

(Updated Sept. 19, 2014, 7:57 p.m.)


Review request for KDevelop.


Changes
-------

Fix segfault and use just QString instead of .componentName().


Repository: kdev-upload


Description
-------

I have ported CMakeList to ECM and Framework based and ported as much source code as I could to compile agains KDevelop and KDevplatform master.


Diffs (updated)
-----

  CMakeLists.txt 8e6baa4 
  kdevuploadplugin.h 335b2b3 
  kdevuploadplugin.cpp c805255 
  profilesfiletree.h 4718b1e 
  profilesfiletree.cpp fffe74e 
  tests/CMakeLists.txt bb4f2f6 
  uploaddialog.cpp 0600a7d 
  uploadjob.cpp b48e58c 
  uploadpreferences.cpp 4b4380e 
  uploadprofiledlg.cpp 930f1c1 
  uploadprofilemodel.cpp 84e8a79 
  uploadprojectmodel.cpp 900b8d0 

Diff: https://git.reviewboard.kde.org/r/120273/diff/


Testing
-------

It compiles, but currently crashes KDevelop whenever project settings are to be opened.


Thanks,

Jakub Caban

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140919/00e72cc3/attachment.html>


More information about the KDevelop-devel mailing list