Review Request 120273: Initial work on porting to Frameworks

[Jakub Caban]

> On Sept. 18, 2014, 10:26 p.m., Aleix Pol Gonzalez wrote:
> > uploadprofilemodel.cpp, line 25
> > <https://git.reviewboard.kde.org/r/120273/diff/1/?file=313291#file313291line25>
> >
> >     Why is this commented out?
> >     You can find it in the KCMUtils framework.
> 
> Jakub Caban wrote:
>     I couldn't overcome it by myself. I know it should be in KCMUtils and it is even found, but I got compile errors:
>     
>     /home/lustmored/projects/kdev-upload/uploadprofilemodel.cpp: In constructor ‘UploadProfileModel::UploadProfileModel(QObject*)’:
>     /home/lustmored/projects/kdev-upload/uploadprofilemodel.cpp:25:90: error: invalid initialization of reference of type ‘const QString&’ from expression of type ‘KComponentData’
>          KSettings::Dispatcher::registerComponent(KComponentData("kdevupload"), this, "revert");
>                                                                                               ^
>     In file included from /home/lustmored/projects/kdev-upload/uploadprofilemodel.cpp:14:0:
>     /usr/include/KF5/KCMUtils/ksettings/dispatcher.h:55:22: error: in passing argument 1 of ‘void KSettings::Dispatcher::registerComponent(const QString&, QObject*, const char*)’
>      KCMUTILS_EXPORT void registerComponent(const QString &componentName, QObject *recv, const char *slot);
>     
>     I'd appreciate some hint as googling failed for me :(

I wasn't linking against KCMUtils - thats where fails came from. It was looking for kde4 version of this function.


- Jakub


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120273/#review66892
-----------------------------------------------------------


On Sept. 19, 2014, 7:35 p.m., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120273/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 7:35 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-upload
> 
> 
> Description
> -------
> 
> I have ported CMakeList to ECM and Framework based and ported as much source code as I could to compile agains KDevelop and KDevplatform master.
> 
> 
> Diffs
> -----
> 
>   uploadprofilemodel.cpp 84e8a79 
>   uploadprojectmodel.cpp 900b8d0 
>   CMakeLists.txt 8e6baa4 
>   kdevuploadplugin.h 335b2b3 
>   kdevuploadplugin.cpp c805255 
>   profilesfiletree.h 4718b1e 
>   profilesfiletree.cpp fffe74e 
>   tests/CMakeLists.txt bb4f2f6 
>   uploaddialog.cpp 0600a7d 
>   uploadjob.cpp b48e58c 
>   uploadpreferences.cpp 4b4380e 
>   uploadprofiledlg.cpp 930f1c1 
> 
> Diff: https://git.reviewboard.kde.org/r/120273/diff/
> 
> 
> Testing
> -------
> 
> It compiles, but currently crashes KDevelop whenever project settings are to be opened.
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140919/ce2040ce/attachment-0001.html>