Review Request 120273: Initial work on porting to Frameworks

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120273/#review66892
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/120273/#comment46638>

    Just remove, no need to comment out :)



profilesfiletree.cpp
<https://git.reviewboard.kde.org/r/120273/#comment46639>

    Again, just remove



uploadjob.cpp
<https://git.reviewboard.kde.org/r/120273/#comment46640>

    Remove the KF5/, if it can't be found, link against KF5::JobWidgets



uploadprofilemodel.cpp
<https://git.reviewboard.kde.org/r/120273/#comment46646>

    Why is this commented out?
    You can find it in the KCMUtils framework.



uploadprofilemodel.cpp
<https://git.reviewboard.kde.org/r/120273/#comment46641>

    I wouldn't read it as a QString, use QUrl?



uploadprofilemodel.cpp
<https://git.reviewboard.kde.org/r/120273/#comment46642>

    toString(), it will make it easier to read when ported to QUrl, which doesn't do the guessing.



uploadprojectmodel.cpp
<https://git.reviewboard.kde.org/r/120273/#comment46643>

    QDateTime uploadTime(m_profile....



uploadprojectmodel.cpp
<https://git.reviewboard.kde.org/r/120273/#comment46644>

    Same as above



uploadprojectmodel.cpp
<https://git.reviewboard.kde.org/r/120273/#comment46645>

    Read as QUrl


I pointed out some issues, but good work otherwise!! :D

- Aleix Pol Gonzalez


On Sept. 18, 2014, 8:08 p.m., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120273/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 8:08 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-upload
> 
> 
> Description
> -------
> 
> I have ported CMakeList to ECM and Framework based and ported as much source code as I could to compile agains KDevelop and KDevplatform master.
> 
> 
> Diffs
> -----
> 
>   profilesfiletree.cpp fffe74e 
>   tests/CMakeLists.txt bb4f2f6 
>   uploaddialog.cpp 0600a7d 
>   uploadjob.cpp b48e58c 
>   uploadpreferences.cpp 4b4380e 
>   uploadprofiledlg.cpp 930f1c1 
>   uploadprofilemodel.cpp 84e8a79 
>   uploadprojectmodel.cpp 900b8d0 
>   CMakeLists.txt 8e6baa4 
>   kdevuploadplugin.h 335b2b3 
>   kdevuploadplugin.cpp c805255 
>   profilesfiletree.h 4718b1e 
> 
> Diff: https://git.reviewboard.kde.org/r/120273/diff/
> 
> 
> Testing
> -------
> 
> It compiles, but currently crashes KDevelop whenever project settings are to be opened.
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140918/c971e2bb/attachment-0001.html>