Review Request 120237: port to ecm_add_test

Kevin Funk kfunk at kde.org
Thu Sep 18 17:55:27 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120237/#review66853
-----------------------------------------------------------

Ship it!


LGTM. Thanks!


languages/cpp/tests/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120237/#comment46622>

    Nitpick: Remove extra newline


- Kevin Funk


On Sept. 17, 2014, 6:41 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120237/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 6:41 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> simplify CMakeLists by using ecm_add_test macro
> 
> 
> Diffs
> -----
> 
>   documentation/manpage/tests/CMakeLists.txt a15188a 
>   documentation/qthelp/tests/CMakeLists.txt f13c8b9 
>   documentation/qthelp/tests/test_qthelpplugin.h PRE-CREATION 
>   documentation/qthelp/tests/test_qthelpplugin.cpp PRE-CREATION 
>   documentation/qthelp/tests/testqthelpplugin.h 035d486 
>   documentation/qthelp/tests/testqthelpplugin.cpp cb97a72 
>   languages/cpp/tests/CMakeLists.txt c5ed97c 
>   languages/plugins/custom-definesandincludes/compilerprovider/tests/CMakeLists.txt 98fc548 
> 
> Diff: https://git.reviewboard.kde.org/r/120237/diff/
> 
> 
> Testing
> -------
> 
> no regression seen
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140918/9831d796/attachment-0001.html>


More information about the KDevelop-devel mailing list