Review Request 120241: Add include path completion

[Milian Wolff]

> On Sept. 17, 2014, 1:17 p.m., Kevin Funk wrote:
> > duchain/clangfilehelpers.cpp, line 1
> > <https://git.reviewboard.kde.org/r/120241/diff/1/?file=312790#file312790line1>
> >
> >     Why did you move those impls into a separate file?
> 
> Sergey Kalinichev wrote:
>     Otherwise I can't use it.
>     When I try to link against kdevclangduchain I get: ...At least one of these targets is not a STATIC_LIBRARY.  Cyclic dependencies are allowed only among static libraries...
>     
>     Otoh using ../clanghelpers.cpp directly doesn't help too, as it depends on too many functions from duchain.

where do you try to link against kdevclangduchain?


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120241/#review66741
-----------------------------------------------------------


On Sept. 18, 2014, 11:56 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120241/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 11:56 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> While the general idea borrowed from oldcpp, the code is mostly rewritten anew.
> 
> 
> Diffs
> -----
> 
>   tests/test_codecompletion.h f9870ea 
>   tests/test_codecompletion.cpp d141fc6 
>   codecompletion/CMakeLists.txt 6d6f9a8 
>   codecompletion/includepathcompletioncontext.h PRE-CREATION 
>   codecompletion/includepathcompletioncontext.cpp PRE-CREATION 
>   codecompletion/model.cpp 114f885 
>   duchain/clangfilehelpers.cpp PRE-CREATION 
>   duchain/clanghelpers.cpp 93f4298 
>   duchain/navigationwidget.h 8283bb6 
>   duchain/navigationwidget.cpp 97010c1 
> 
> Diff: https://git.reviewboard.kde.org/r/120241/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140918/91e8876e/attachment.html>