Review Request 120240: Add utility to modify include paths

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120240/#review66720
-----------------------------------------------------------

Ship it!


Pretty good, I like it - thanks! Some small nitpicks. I'm wondering though whether the CLI API is good as-is or whether named arguments and reading from STDIN wouldn't be nicer for scripting.


languages/plugins/custom-definesandincludes/includepathsconverter.cpp
<https://git.reviewboard.kde.org/r/120240/#comment46507>

    please break this overly long line
    
        parser.setApplicationDescription("...\n"
                                         "...\n"
                                         "...");



languages/plugins/custom-definesandincludes/includepathsconverter.cpp
<https://git.reviewboard.kde.org/r/120240/#comment46509>

    instead of using positional arguments, I'd prefer named arguments
    
        kdev_includepathsconvert -p $project -s $subdir
    
    also, I'd read the include dirs from STDIN, users can then easily pipe in the files which is nice for scripting, I think.



languages/plugins/custom-definesandincludes/includepathsconverter.cpp
<https://git.reviewboard.kde.org/r/120240/#comment46508>

    if (args.isEmpty())


- Milian Wolff


On Sept. 17, 2014, 7:31 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120240/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 7:31 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 338968
>     http://bugs.kde.org/show_bug.cgi?id=338968
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This utility makes it possible to modify project include paths from command line.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/CMakeLists.txt 8bd32c4 
>   languages/plugins/custom-definesandincludes/includepathsconverter.h PRE-CREATION 
>   languages/plugins/custom-definesandincludes/includepathsconverter.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120240/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140917/82eec9e1/attachment.html>